-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAS-438 | Touch up the readme with more information #569
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 32.56% 32.90% +0.33%
==========================================
Files 525 518 -7
Lines 26533 26189 -344
Branches 858 774 -84
==========================================
- Hits 8640 8617 -23
+ Misses 17774 17448 -326
- Partials 119 124 +5 ☔ View full report in Codecov by Sentry. |
@abergs @jonashendrickx any comments? 🙂 |
@Tyrrrz Could we perhaps include a link to our demo or a gif on the UX? I think it's powerful. |
Do we have such a demo/gif already? |
@abergs I added the demo video. There were two options on how to embed it into the readme:
I went with option 2. This is what it looks like: https://github.com/bitwarden/passwordless-server/tree/Tyrrrz-patch-1?tab=readme-ov-file#demo As a side note, I was able to record the Windows Hello popup without issues, so the user can see the whole authentication process. Let me know if this is good enough. |
Solid! @Tyrrrz |
No description provided.