-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up accounts with unconfirmed users #561
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
- Coverage 32.57% 32.53% -0.04%
==========================================
Files 525 526 +1
Lines 26509 26540 +31
Branches 850 851 +1
==========================================
Hits 8635 8635
- Misses 17755 17786 +31
Partials 119 119 ☔ View full report in Codecov by Sentry. |
src/AdminConsole/BackgroundServices/UnconfirmedAccountCleanUpBackgroundService.cs
Outdated
Show resolved
Hide resolved
src/AdminConsole/BackgroundServices/UnconfirmedAccountCleanUpBackgroundService.cs
Outdated
Show resolved
Hide resolved
…ackgroundService.cs Co-authored-by: Oleksii Holub <1935960+Tyrrrz@users.noreply.github.com>
…ackgroundService.cs Co-authored-by: Oleksii Holub <1935960+Tyrrrz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fair!
Do we want to just log what orgs would be deleted instead of actually deleting data and verify it looks correct?
Ticket
Description
We've noticed a large influx of accounts being created and then never logging in to create an account. This will help identify those accounts and remove them after 30 days of no activity.
Shape
This adds setting EmailConfirmed for the user when they sign into passwordless adminconsole.
This also creates a background job that will clean up
Checklist
I did the following to ensure that my changes were tested thoroughly:
I did the following to ensure that my changes do not introduce security vulnerabilities: