Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up accounts with unconfirmed users #561

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Apr 18, 2024

Ticket

Description

We've noticed a large influx of accounts being created and then never logging in to create an account. This will help identify those accounts and remove them after 30 days of no activity.

Shape

This adds setting EmailConfirmed for the user when they sign into passwordless adminconsole.

This also creates a background job that will clean up

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • I can successfully log in and EmailConfirmed is set successfully.

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • N/A

@jrmccannon jrmccannon requested a review from a team April 18, 2024 15:15
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 32.53%. Comparing base (48797e9) to head (c889604).

Files Patch % Lines
src/AdminConsole/Services/DataService.cs 0.00% 19 Missing ⚠️
...ices/UnconfirmedAccountCleanUpBackgroundService.cs 0.00% 11 Missing ⚠️
...sole/Services/MagicLinks/MagicLinkSignInManager.cs 0.00% 4 Missing ⚠️
src/AdminConsole/Program.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   32.57%   32.53%   -0.04%     
==========================================
  Files         525      526       +1     
  Lines       26509    26540      +31     
  Branches      850      851       +1     
==========================================
  Hits         8635     8635              
- Misses      17755    17786      +31     
  Partials      119      119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jrmccannon and others added 2 commits April 18, 2024 10:49
…ackgroundService.cs

Co-authored-by: Oleksii Holub <1935960+Tyrrrz@users.noreply.github.com>
…ackgroundService.cs

Co-authored-by: Oleksii Holub <1935960+Tyrrrz@users.noreply.github.com>
Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fair!

Do we want to just log what orgs would be deleted instead of actually deleting data and verify it looks correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants