Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Stripe SDK #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade Stripe SDK #537

wants to merge 1 commit into from

Conversation

jonashendrickx
Copy link
Member

Description

Upgrades the Stripe SDK

Shape

We would have to monitor a production deployment, and upgrade the Stripe API version in the Stripe dashboard the exact moment the load balancer swaps the deployment slots.

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx added config changes dependencies Pull requests that update a dependency file labels Apr 3, 2024
@jonashendrickx jonashendrickx requested a review from a team as a code owner April 3, 2024 09:46
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.38%. Comparing base (b948250) to head (56f5a0b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   32.38%   32.38%           
=======================================
  Files         518      518           
  Lines       26530    26530           
  Branches      849      849           
=======================================
  Hits         8591     8591           
  Misses      17821    17821           
  Partials      118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx
Copy link
Member Author

@abergs If you merge it now we get plenty of time to test.

@abergs
Copy link
Member

abergs commented Apr 22, 2024

@jonashendrickx I don't think we need to upgrade the API version in the stripe dashboard if we update the SDK, are you sure about this?

@jonashendrickx
Copy link
Member Author

jonashendrickx commented Apr 24, 2024

@jonashendrickx I don't think we need to upgrade the API version in the stripe dashboard if we update the SDK, are you sure about this?

Yes. Setup the Stripe CLI and add a local listener. Then upgrade the Stripe SDK to verify. It will start throwing exceptions and return a 500.

We are only 2 major versions behind I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config changes dependencies Pull requests that update a dependency file hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants