-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step up v2 #530
Open
jrmccannon
wants to merge
92
commits into
main
Choose a base branch
from
step-up-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Step up v2 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he list of configs. Added tests.
# Conflicts: # src/AdminConsole/Components/Shared/Icons/PencilSquareIcon.razor
… to service. Added service to Fido2Service. Added new ordefault method.
…tions to reflect using bigint for TimeSpan in MsSql
Tyrrrz
reviewed
May 15, 2024
...nents/Pages/App/Settings/AuthenticationConfiguration/AuthenticationConfigurationFormModel.cs
Show resolved
Hide resolved
...ponents/Pages/App/Settings/AuthenticationConfiguration/AuthenticationConfigurationForm.razor
Outdated
Show resolved
Hide resolved
# Conflicts: # src/Common/Common.csproj
Tyrrrz
previously approved these changes
May 16, 2024
...ponents/Pages/App/Settings/AuthenticationConfiguration/AuthenticationConfigurationForm.razor
Outdated
Show resolved
Hide resolved
...inConsole/Components/Pages/App/Settings/SettingsComponents/AuthenticationConfiguration.razor
Outdated
Show resolved
Hide resolved
...ponents/Pages/App/Settings/AuthenticationConfiguration/AuthenticationConfigurationForm.razor
Show resolved
Hide resolved
# Conflicts: # src/AdminConsole/AdminConsole.csproj
Tyrrrz
previously approved these changes
May 30, 2024
jonashendrickx
previously approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
This is the v2 of the step up API (really just adding Purpose to sign in). This also adds the authentication configuration endpoints to allow for admin console (or an API user) to set, get and create new step up purposes.
Shape
AuthenticationConfiguration
Screenshots
Addition to Settings.cshtml
Edit
Create
Delete
Checklist
I did the following to ensure that my changes were tested thoroughly:
I did the following to ensure that my changes do not introduce security vulnerabilities: