Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step up v2 #530

Open
wants to merge 92 commits into
base: main
Choose a base branch
from
Open

Step up v2 #530

wants to merge 92 commits into from

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Apr 1, 2024

Ticket

Description

This is the v2 of the step up API (really just adding Purpose to sign in). This also adds the authentication configuration endpoints to allow for admin console (or an API user) to set, get and create new step up purposes.

Shape

  • Adds purpose to SignInToken
  • Adds purpose to SignInVerifyDTO
  • Adds two default purposes of SignIn and StepUp
  • Adds new table AuthenticationConfiguration
  • Adds new AdminConsole Settings page.

Screenshots

Addition to Settings.cshtml
image

Edit
image

Create
image

Delete
image

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • validated existing sign in worked
  • validated new step up flow works
  • validated magic links worked
  • validated new admin console settings worked

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • validated you could not change tenant from blazor pages
  • ran existing integration tests to validate nothing broke

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 55.60027% with 662 lines in your changes missing coverage. Please review.

Project coverage is 34.02%. Comparing base (75b7715) to head (8038663).

Files Patch % Lines
...6151601_AddAuthenticationConfiguration.Designer.cs 0.00% 449 Missing ⚠️
...vice/Migrations/Mssql/MsSqlContextModelSnapshot.cs 0.00% 40 Missing ⚠️
...ce/Migrations/Sqlite/SqliteContextModelSnapshot.cs 0.00% 40 Missing ⚠️
...ttingsComponents/AuthenticationConfiguration.razor 0.00% 37 Missing ⚠️
...e/20240416151601_AddAuthenticationConfiguration.cs 0.00% 22 Missing ⚠️
...onfiguration/EditAuthenticationConfiguration.razor 0.00% 17 Missing ⚠️
.../AdminConsole/Services/ScopedPasswordlessClient.cs 0.00% 12 Missing ⚠️
...onfiguration/AuthenticationConfigurationForm.razor 0.00% 11 Missing ⚠️
...figuration/AuthenticationConfigurationFormModel.cs 0.00% 10 Missing ⚠️
...Configuration/NewAuthenticationConfiguration.razor 0.00% 9 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   32.91%   34.02%   +1.11%     
==========================================
  Files         517      539      +22     
  Lines       26172    27594    +1422     
  Branches      772      805      +33     
==========================================
+ Hits         8614     9390     +776     
- Misses      17433    18076     +643     
- Partials      125      128       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrmccannon jrmccannon requested review from jonashendrickx and a team May 3, 2024 15:13
@jrmccannon jrmccannon requested review from Tyrrrz and a team May 28, 2024 19:45
# Conflicts:
#	src/AdminConsole/AdminConsole.csproj
Tyrrrz
Tyrrrz previously approved these changes May 30, 2024
jonashendrickx
jonashendrickx previously approved these changes Jun 2, 2024
@jrmccannon jrmccannon dismissed stale reviews from jonashendrickx and Tyrrrz via 8038663 June 4, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants