-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing AppFeature records #489
base: main
Are you sure you want to change the base?
Conversation
…creating the admin console app.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 32.38% 32.94% +0.55%
==========================================
Files 518 522 +4
Lines 26533 27390 +857
Branches 845 845
==========================================
+ Hits 8594 9023 +429
- Misses 17821 18249 +428
Partials 118 118 ☔ View full report in Codecov by Sentry. |
IsMagicLinksEnabled, | ||
AllowAttestation, | ||
MagicLinkEmailMonthlyQuota) | ||
SELECT ai.Tenant, 0, 0, NULL, NULL, 1, 1, 0, 2000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 1000 sounds more resonable since that is what we use for external apps today.
I notice you set NULL on MaxUsers - what is the result of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. When MaxUsers is NULL, there is no max.
All apps that I've seen that don't have this record are test applications. We can easily set this to something however.
Looks mostly good, see comment |
Ticket
No ticket.
Description
With the replacement of magic links in Admin Console with the API, it is relying on the AppFeature record to exist and for the monthly quota to be set. With it not set, AdminConsole can't send magic links.
Shape
Screenshots
N/A
Checklist
I did the following to ensure that my changes were tested thoroughly:
I did the following to ensure that my changes do not introduce security vulnerabilities: