Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7186] Cancel the Extension when an exception occurs #3126

Conversation

dinisvieira
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Currently the Autofill Extension can get stuck in a Loading if an exception occurss.
We also suspect there might be other errors causing our extension to get disabled by Apple and/or the ASStore to be deleted.
This is still under investigation.

Code changes

  • LoginListViewController.cs: Added Cancel after showing error to user. This way the Extension closes gracefully

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@github-actions github-actions bot added the iOS label Mar 31, 2024
@dinisvieira dinisvieira closed this Apr 2, 2024
@dinisvieira dinisvieira deleted the bug/PM-7186-avoid-extension-issues-on-error branch April 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant