Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7191] Add fallback to showing passwords when trying to request passkey for websites that only support password #3125

Conversation

dinisvieira
Copy link
Contributor

@dinisvieira dinisvieira commented Mar 31, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When the user tries to autofill a webpage and there’s a passkey related error, they’ll see our iOS extension open with an error message. After pressing ok, the activity indicator / loading spinner isn’t removed and search won’t work, preventing users from autofilling other credentials.
We should fallback to passwords in this scenario. This fallback is based on calling SilentCredentialDiscoveryAsync()

Code changes

During initialization we could call SilentCredentialDiscoveryAsync() to check if any passkey exists for the given RPId, if not we configure the UI to show Passwords.

  • LoginListViewController.cs:

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@github-actions github-actions bot added the iOS label Mar 31, 2024
@dinisvieira dinisvieira marked this pull request as ready for review April 1, 2024 11:11
@dinisvieira dinisvieira requested a review from a team as a code owner April 1, 2024 11:11
@dinisvieira dinisvieira marked this pull request as draft April 1, 2024 11:12
@dinisvieira dinisvieira removed the request for review from andrebispo5 April 1, 2024 11:13
@coroiu coroiu removed their request for review April 2, 2024 11:33
@dinisvieira dinisvieira closed this Apr 2, 2024
@dinisvieira dinisvieira deleted the bug/PM-7191-fallback-password-ios-passkey-website branch April 2, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant