Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5832] Use package name for autofill when website is not set #2950

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

larena1
Copy link
Contributor

@larena1 larena1 commented Jan 22, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When an app presents a webview, Bitwarden will populate Website with the webview's url. Because Website is not null, PackageName will not be assigned. If the app is not on Bitwarden's built-in browsers list, Website will be unassigned after that, effectively rendering autofill unusable.

This PR swaps the two blocks so that package name will be assigned and autofill will be offered.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@larena1 larena1 requested a review from a team as a code owner January 22, 2024 23:18
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-5832

@bitwarden-bot bitwarden-bot changed the title Use package name for autofill when website is not set [PM-5832] Use package name for autofill when website is not set Jan 22, 2024
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailsb508c62e-936e-410a-913a-560fa176307b

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants