[PM-3424] Make mobile app navigation significantly more responsive during use

[quexten]

Type of change

• Bug fix
• New feature development
• Tech debt (refactoring, code cleanup, dependency upgrades, etc)
• Build/deploy pipeline (DevOps)
• Other

Objective

On each content page navigation in the mobile app, a significant delay (400ms) occurs in which a loading spinner is shown, even if nothing is loading, making the app feel quite laggy during use. This delay is introduced by a Task.Delay of 400ms on the codepath that displays the content. I'm not quite sure why the delay is so long, by the variable name it is some kind of animation delay, but the transition animation has long finished by the time the delay is done.

Either way, removing the delay seems to cause no issues and makes the app feel much more responsive (see the videos below).

Code changes

• file.ext: Description of what was changed and why

Screenshots

not_fixed.mp4

fixed.mp4

Before you submit

• Please check for formatting errors (dotnet format --verify-no-changes) (required)
• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-3424

[vvolkgang]

@quexten great idea!

@fedemkr @mpbw2 these animation delays used to be common in the past to prevent navigation animation stuttering (and at some point even page initialisation race conditions due to framework bugs), specially on older devices. I do recall this being a bigger issue with Drawers and not modals, are you aware of reasons why we should keep it?