Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-3041] Add the possibility to require master password with biometrics on app reset #2621

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abarghoud
Copy link

@abarghoud abarghoud commented Jul 16, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR addresses issue #2032, which is the possibility of setting if the app should ask for a master password with biometrics authentication on restart.

Code changes

  • LockPageViewModel.cs: The addition of a condition to determine if the master password should be used instead
  • SettingsPageViewModel.cs: Some refactoring to enable code reuse, and the code allowing to show the popup just after biometrics set up to ask if the master password should be required after the app reset
  • AppResources.Designer.cs: Removal of Pin prefix from the translation key
  • AppResources.resx: Removal of Pin prefix from the translation key
  • IStateService.cs: The getter and setter methods declaration for the new option
  • Constants.cs: The new option key's constant
  • src/Core/Services/StateService.cs: The getter and setter methods implementation for the new option

Screenshots

Screenshot_1689472687

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2023

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-3041

@bitwarden-bot bitwarden-bot changed the title Add the possibility to require master password with biometrics on app reset [PM-3041] Add the possibility to require master password with biometrics on app reset Jul 16, 2023
@bitwarden-bot
Copy link

bitwarden-bot commented Jul 16, 2023

Logo
Checkmarx One – Scan Summary & Details9833018c-5b7d-452d-bb01-48d67176c2fc

No New Or Fixed Issues Found

@fedemkr fedemkr requested review from a team July 17, 2023 13:08
@komidawi
Copy link

Hi, would something be done with this PR?
I'd love to see this feature deployed as I've been waiting for it for months until I came across #2032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants