New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requiring providing master password on application restart is not respected when a pin is set together with biometrics unlock #2032
Comments
Thinking about it bit more, this setting was probably meant to require the master pass instead of pin, but if pin is combined with biometrics, then you can still unlock with biometrics and you don't have to provide the master pass. Should the question about requiring master pass to be provided when application restarts be actually changed to a checkbox at the top level so that it affects both pin unlocking and biometrics? |
@mfronczyk @fedemkr Hi I would like to contribute to this issue can you let me know how I can solve this issue. |
In my opinion it should be like this:
|
Hi there, thank you very much for the report, the feedback and the interest in contributing to this project 😄 . I talked with the team and we think the simplest approach here would be to have the same flow as in "Unlock with PIN" but on "Unlock with Biometrics". So in essence, the flow in Settings would be:
With this approach the user has more flexibility to manage the settings separately. So if you would like to tackle this @Mayuresh0072, you would have to add the new prompt to settings (following the same approach as it's done with PIN) and update the logic on app restart. App Restart FlowMPB: Master password on app reset for Biometrics flowchart TD
A[App Starts on Lock view] --> B{Is Biometrics enabled?}
B -- Yes --> MPB{Is MPB enabled?}
B -- No --> PE
MPB -- Yes --> MP[Ask Master Password]
MPB -- No --> S[Scan biometrics]
S --> BS{Scan successful?}
BS -- Yes --> E[Access allowed]
BS -- No --> PE{Is PIN enabled?}
PE -- Yes --> MPP{Is MPP enabled?}
PE -- No --> MP
MPP -- Yes --> MP
MPP -- No --> P[Ask PIN]
MP -- Valid --> E
P -- Valid --> E
|
@fedemkr Hey, because there is no recent contribution to this issue: Is it still open? If so, I would like to try and solve this issue. |
Hi @mariemllr thank you so much for the interest and yes, you can contribute solving this issue 😄 |
Hi @fedemkr, I noticed that there hadn't been any updates regarding this issue, so I decided to take the initiative and work on it. I have just submitted a PR. |
Hi @abarghoud thank you so much for taking the initiative and contributing! |
I see that PR #2621 still haven't been touched by anyone. |
I've created this issue as my primary driver was to type in the password from time to time in order not to forget it, but I must say I don't need it anymore on iPhone. I use Bitwarden on Mac also, and I type in the password there. That said, the change might be good anyway :-) However, I'm happy with just closing it if that's what community prefers. |
Hello @fedemkr, I was wondering if the issue is still relevant. I noticed that the PR has been there for a while without any updates. If it's still needed, I'd be happy to rebase it to resolve conflicts and move things forward. |
Steps To Reproduce
(These might not be the exact English labels because my app renders in Polish, but I think it's close enough to reproduce)
Expected Result
Application should require the master password in order to unlock
Actual Result
It can be unlocked using master password or biometrics
Screenshots or Videos
No response
Additional Context
I'd basically like Bitwarden to require providing the master password from time to time in order to help me remembering it (not forgetting). I couldn't find such option, but it seemed the setting a pin and then requiring the master pass to be provided on restart would help he to mimic such behavior, but it doesn't seem to work as I expected.
I'd also be grateful if you could let me know if there's somewhere an option to request providing the master key from time to time.
Operating System
iOS
Operating System Version
15.6
Device
iPhone 13 Pro
Build Version
2022.6.2 (1951)
Beta
The text was updated successfully, but these errors were encountered: