PM-7186 Added fallback in case of exception that loads password list

bitwarden · Apr 2, 2024 · 769ac28 · 769ac28
1 parent 4633fea
commit 769ac28
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/iOS.Autofill/LoginListViewController.cs b/src/iOS.Autofill/LoginListViewController.cs
@@ -215,9 +215,10 @@ public async Task DoFido2GetAssertionAsync(IFido2GetAssertionUserInterface fido2
                 {
                     if (Context?.IsExecutingWithoutUserInteraction == false)
                     {
-                        await _platformUtilsService.Value.ShowDialogAsync(
-                            string.Format(AppResources.ThereWasAProblemReadingAPasskeyForXTryAgainLater, Context.PasskeyCredentialRequestParameters.RelyingPartyIdentifier),
-                            AppResources.ErrorReadingPasskey);
+                        TableView.SectionHeaderHeight = 0; 
+                        Context.IsPasswordFallback = true;
+                        await ReloadItemsAsync();
+                        _alreadyLoadItemsOnce = true;
                     }
                 }
                 catch (Exception ex)

diff --git a/src/iOS.Autofill/Models/Context.cs b/src/iOS.Autofill/Models/Context.cs
@@ -70,7 +70,9 @@ public ASPasskeyCredentialIdentity PasskeyCredentialIdentity
 
         public bool IsPasskey => PasskeyCredentialRequest != null;
 
-        public bool IsPreparingListForPasskey => PasskeyCredentialRequestParameters != null;
+        public bool IsPasswordFallback { get; set; }
+
+        public bool IsPreparingListForPasskey => PasskeyCredentialRequestParameters != null && !IsPasswordFallback;
 
         public bool IsCreatingOrPreparingListForPasskey => IsCreatingPasskey || IsPreparingListForPasskey;
     }