removed monospaced font from username field

bitwarden · Nov 9, 2016 · 0257c5b · 0257c5b
1 parent 3b1bb02
commit 0257c5b
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 17 deletions.
diff --git a/src/App/Controls/FormEntryCell.cs b/src/App/Controls/FormEntryCell.cs
@@ -10,7 +10,7 @@ public class FormEntryCell : ExtendedViewCell
         public FormEntryCell(
             string labelText,
             Keyboard entryKeyboard = null,
-            bool IsPassword = false,
+            bool isPassword = false,
             VisualElement nextElement = null,
             bool useLabelAsPlaceholder = false,
             string imageSource = null,
@@ -32,7 +32,7 @@ public class FormEntryCell : ExtendedViewCell
             {
                 Keyboard = entryKeyboard,
                 HasBorder = false,
-                IsPassword = IsPassword,
+                IsPassword = isPassword,
                 AllowClear = true,
                 HorizontalOptions = LayoutOptions.FillAndExpand,
                 WidthRequest = 1,

diff --git a/src/App/Pages/Lock/LockPasswordPage.cs b/src/App/Pages/Lock/LockPasswordPage.cs
@@ -38,7 +38,7 @@ public void Init()
                 Android: new Thickness(15, 8),
                 WinPhone: new Thickness(15, 20));
 
-            PasswordCell = new FormEntryCell(AppResources.MasterPassword, IsPassword: true,
+            PasswordCell = new FormEntryCell(AppResources.MasterPassword, isPassword: true,
                 useLabelAsPlaceholder: true, imageSource: "lock", containerPadding: padding);
 
             PasswordCell.Entry.ReturnType = Enums.ReturnType.Go;

diff --git a/src/App/Pages/LoginPage.cs b/src/App/Pages/LoginPage.cs
@@ -55,7 +55,7 @@ private void Init()
                 Android: new Thickness(15, 8),
                 WinPhone: new Thickness(15, 20));
 
-            PasswordCell = new FormEntryCell(AppResources.MasterPassword, IsPassword: true,
+            PasswordCell = new FormEntryCell(AppResources.MasterPassword, isPassword: true,
                 useLabelAsPlaceholder: true, imageSource: "lock", containerPadding: padding);
             EmailCell = new FormEntryCell(AppResources.EmailAddress, nextElement: PasswordCell.Entry,
                 entryKeyboard: Keyboard.Email, useLabelAsPlaceholder: true, imageSource: "envelope",

diff --git a/src/App/Pages/RegisterPage.cs b/src/App/Pages/RegisterPage.cs
@@ -47,10 +47,10 @@ private void Init()
 
             PasswordHintCell = new FormEntryCell("Master Password Hint (optional)", useLabelAsPlaceholder: true,
                 imageSource: "lightbulb", containerPadding: padding);
-            ConfirmPasswordCell = new FormEntryCell("Re-type Master Password", IsPassword: true,
+            ConfirmPasswordCell = new FormEntryCell("Re-type Master Password", isPassword: true,
                 nextElement: PasswordHintCell.Entry, useLabelAsPlaceholder: true, imageSource: "lock",
                 containerPadding: padding);
-            PasswordCell = new FormEntryCell(AppResources.MasterPassword, IsPassword: true,
+            PasswordCell = new FormEntryCell(AppResources.MasterPassword, isPassword: true,
                 nextElement: ConfirmPasswordCell.Entry, useLabelAsPlaceholder: true, imageSource: "lock",
                 containerPadding: padding);
             EmailCell = new FormEntryCell(AppResources.EmailAddress, nextElement: PasswordCell.Entry,

diff --git a/src/App/Pages/Vault/VaultAddSitePage.cs b/src/App/Pages/Vault/VaultAddSitePage.cs
@@ -41,20 +41,18 @@ public VaultAddSitePage()
         private void Init()
         {
             var notesCell = new FormEditorCell(height: 90);
-            PasswordCell = new FormEntryCell(AppResources.Password, IsPassword: true, nextElement: notesCell.Editor,
+            PasswordCell = new FormEntryCell(AppResources.Password, isPassword: true, nextElement: notesCell.Editor,
                 useButton: true);
             PasswordCell.Button.Image = "eye";
             PasswordCell.Button.Clicked += PasswordButton_Clicked;
             PasswordCell.Entry.DisableAutocapitalize = true;
             PasswordCell.Entry.Autocorrect = false;
+            PasswordCell.Entry.FontFamily = Device.OnPlatform(iOS: "Courier", Android: "monospace", WinPhone: "Courier");
 
             var usernameCell = new FormEntryCell(AppResources.Username, nextElement: PasswordCell.Entry);
             usernameCell.Entry.DisableAutocapitalize = true;
             usernameCell.Entry.Autocorrect = false;
 
-            usernameCell.Entry.FontFamily = PasswordCell.Entry.FontFamily = Device.OnPlatform(
-                iOS: "Courier", Android: "monospace", WinPhone: "Courier");
-
             var uriCell = new FormEntryCell(AppResources.URI, Keyboard.Url, nextElement: usernameCell.Entry);
             var nameCell = new FormEntryCell(AppResources.Name, nextElement: uriCell.Entry);
 

diff --git a/src/App/Pages/Vault/VaultEditSitePage.cs b/src/App/Pages/Vault/VaultEditSitePage.cs
@@ -46,22 +46,20 @@ private void Init()
             var notesCell = new FormEditorCell(height: 90);
             notesCell.Editor.Text = site.Notes?.Decrypt();
 
-            PasswordCell = new FormEntryCell(AppResources.Password, IsPassword: true, nextElement: notesCell.Editor,
+            PasswordCell = new FormEntryCell(AppResources.Password, isPassword: true, nextElement: notesCell.Editor,
                 useButton: true);
             PasswordCell.Entry.Text = site.Password?.Decrypt();
             PasswordCell.Button.Image = "eye";
             PasswordCell.Button.Clicked += PasswordButton_Clicked;
             PasswordCell.Entry.DisableAutocapitalize = true;
             PasswordCell.Entry.Autocorrect = false;
+            PasswordCell.Entry.FontFamily = Device.OnPlatform(iOS: "Courier", Android: "monospace", WinPhone: "Courier");
 
             var usernameCell = new FormEntryCell(AppResources.Username, nextElement: PasswordCell.Entry);
             usernameCell.Entry.Text = site.Username?.Decrypt();
             usernameCell.Entry.DisableAutocapitalize = true;
             usernameCell.Entry.Autocorrect = false;
 
-            usernameCell.Entry.FontFamily = PasswordCell.Entry.FontFamily =
-                Device.OnPlatform(iOS: "Courier", Android: "monospace", WinPhone: "Courier");
-
             var uriCell = new FormEntryCell(AppResources.URI, Keyboard.Url, nextElement: usernameCell.Entry);
             uriCell.Entry.Text = site.Uri?.Decrypt();
             var nameCell = new FormEntryCell(AppResources.Name, nextElement: uriCell.Entry);

diff --git a/src/App/Pages/Vault/VaultViewSitePage.cs b/src/App/Pages/Vault/VaultViewSitePage.cs
@@ -64,9 +64,7 @@ private void Init()
             }
             PasswordCell.Button1.Command = new Command(() => Model.RevealPassword = !Model.RevealPassword);
             PasswordCell.Button2.Command = new Command(() => Copy(Model.Password, AppResources.Password));
-
-            UsernameCell.Value.FontFamily = PasswordCell.Value.FontFamily = Device.OnPlatform(
-                iOS: "Courier", Android: "monospace", WinPhone: "Courier");
+            PasswordCell.Value.FontFamily = Device.OnPlatform(iOS: "Courier", Android: "monospace", WinPhone: "Courier");
 
             // URI
             UriCell = new LabeledValueCell(AppResources.Website, button1Text: AppResources.Launch);