[PM-6606] remove onboarding feature flag

[merissaacosta]

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

removes the vault-onboarding feature flag for the end-user onboarding component since this feature is live

Code changes

• **vault-onboarding.component.html ** removed showOnboardingAccess so that it doesnt check the feature flag value
• vault-onboarding.component.ts removing getting feature flag & storing it in variable
• feature-flag.enum.ts removes corresponding flag from shared enum
• vault-onboarding.component.spec.ts remove ConfigService from being mocked in the spec

Before you submit

• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team
• Ensure that all UI additions follow WCAG AA requirements

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.79%. Comparing base (7f91e84) to head (a881f2a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9178   +/-   ##
=======================================
  Coverage   27.78%   27.79%           
=======================================
  Files        2422     2422           
  Lines       70235    70228    -7     
  Branches    13097    13095    -2     
=======================================
- Hits        19518    19517    -1     
+ Misses      49197    49192    -5     
+ Partials     1520     1519    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – d0b8c43f-bfc2-4440-a6cf-38fab58b3467

No New Or Fixed Issues Found