-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-4961]anon-layout login component migrated #9167
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9167 +/- ##
=======================================
Coverage 28.05% 28.05%
=======================================
Files 2391 2391
Lines 70521 70525 +4
Branches 13207 13207
=======================================
+ Hits 19782 19789 +7
+ Misses 49174 49171 -3
Partials 1565 1565 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
…961-Migrate-login-component
/> | ||
</bit-form-field> | ||
</div> | ||
<div class="tw-w-96"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ : Is there a reason this was changed from tw-mx-auto
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we don't need any of these bcz Anon-layout itself has all these class so I'm removing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ike-kottlowski based on this comment, I have removed the tw-w-96 from the html as advised in the comment, but the UI look clumsy can you please take a look and guide me, Thank you!.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious as to the reasoning I think using the tw-w-96
to meet the visual requirement is acceptable.
You can change it to tw-w-96
cc: @willmartian
…961-Migrate-login-component
…961-Migrate-login-component
Type of change
Objective
Migrate the login component to use the component library.
Code changes
Screenshots
Untitled.video.-.Made.with.Clipchamp.1.mp4