Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-4961]anon-layout login component migrated #9167

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vinith-kovan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Migrate the login component to use the component library.

Code changes

  • login.component.html: Added form group and bit form fields
  • login.component.ts: Added new form group , converted submit to arrow function
  • oss-routing.module.ts: Added Routing for Anon layout wrapper component.

Screenshots

Untitled.video.-.Made.with.Clipchamp.1.mp4

@vinith-kovan vinith-kovan requested a review from a team as a code owner May 14, 2024 08:21
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 28.05%. Comparing base (81c1456) to head (9510774).

Files Patch % Lines
apps/web/src/app/auth/login/login.component.ts 0.00% 3 Missing ⚠️
apps/web/src/app/oss-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9167   +/-   ##
=======================================
  Coverage   28.05%   28.05%           
=======================================
  Files        2391     2391           
  Lines       70521    70525    +4     
  Branches    13207    13207           
=======================================
+ Hits        19782    19789    +7     
+ Misses      49174    49171    -3     
  Partials     1565     1565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 14, 2024

Logo
Checkmarx One – Scan Summary & Detailsfb871e94-d170-4fb7-8b17-eabdd25fb7b0

No New Or Fixed Issues Found

/>
</bit-form-field>
</div>
<div class="tw-w-96">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ : Is there a reason this was changed from tw-mx-auto?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we don't need any of these bcz Anon-layout itself has all these class so I'm removing it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Hi @ike-kottlowski based on this comment, I have removed the tw-w-96 from the html as advised in the comment, but the UI look clumsy can you please take a look and guide me, Thank you!.

image
tw-w-96 added one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious as to the reasoning I think using the tw-w-96 to meet the visual requirement is acceptable.

You can change it to tw-w-96

cc: @willmartian

apps/web/src/app/oss-routing.module.ts Outdated Show resolved Hide resolved
apps/web/src/app/oss-routing.module.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants