Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2598] Only call PaymentMethodWarningService when FF is on #9161

Merged
merged 1 commit into from
May 16, 2024

Conversation

amorask-bitwarden
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden commented May 13, 2024

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Adding a payment method using the modal on the Payment Method page currently succeeds, but throws a Toast error because the unneeded invocation of the PaymentMethodWarningService fails. We should only invoke this if the FF is on.

Screen.Recording.2024-05-13.at.3.00.00.PM.mov

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner May 13, 2024 19:02
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 27.70%. Comparing base (dd41bcb) to head (dd4e8b4).

Files Patch % Lines
.../billing/shared/adjust-payment-dialog.component.ts 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9161   +/-   ##
=======================================
  Coverage   27.70%   27.70%           
=======================================
  Files        2418     2418           
  Lines       70019    70022    +3     
  Branches    13052    13052           
=======================================
+ Hits        19401    19403    +2     
- Misses      49106    49107    +1     
  Partials     1512     1512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd08e9bb8-6c06-45cf-981b-9c44a0cc1ce5

No New Or Fixed Issues Found

@github-actions github-actions bot temporarily deployed to Web Vault - US QA Cloud May 16, 2024 01:37 Inactive
@amorask-bitwarden amorask-bitwarden removed the needs-qa Marks a PR as requiring QA approval label May 16, 2024
@amorask-bitwarden amorask-bitwarden merged commit 43e1d0a into main May 16, 2024
31 of 37 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/AC-2598/payment-method-modal-bug branch May 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants