Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8059] Clarify warning message #9141

Merged
merged 2 commits into from
May 15, 2024

Conversation

lorenzoverardo
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Continues #7155 as it looks stale.

Resolves #7084

This PR updates the warning message as mentioned here to enhance clarity and user understanding. The modification aims to improve the user experience by providing more informative and direct communication.

Code changes

  • apps/web/src/locales/en/messages.json: Updated the warning message text. This change was made to make the warning more clear and informative for users.
  • apps/web/src/app/auth/settings/security/change-kdf/change-kdf-confirmation.component.html: Renamed warning message variable.
  • apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html: Renamed warning message variable.

Screenshots

screenshot

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@lorenzoverardo lorenzoverardo requested a review from a team as a code owner May 11, 2024 14:42
@CLAassistant
Copy link

CLAassistant commented May 11, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-8059

@bitwarden-bot bitwarden-bot changed the title Clarify warning message [PM-8059] Clarify warning message May 11, 2024
@lorenzoverardo
Copy link
Contributor Author

cc @djsmith85

@trmartin4 trmartin4 requested review from trmartin4 and removed request for ike-kottlowski May 12, 2024 14:17
@trmartin4
Copy link
Member

@lorenzoverardo thank you for this change! It has been approved and is moving to our QA team for validation.

@trmartin4
Copy link
Member

@lorenzoverardo this has been reviewed and approved by our QA team. I'll be merging it in now. It will be in our next web client release.

Thank you for your contribution!

@trmartin4 trmartin4 merged commit c19a640 into bitwarden:main May 15, 2024
54 of 59 checks passed
@lorenzoverardo lorenzoverardo deleted the issue-7084/fix-wording branch May 16, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The words "and complete two step login setup" are wrong
4 participants