[AC-2447] Allow the UI to save and close dialog when user removes final Can Manage Collection of an item #9136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… longer manage cipher after requested update
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9136 +/- ##
==========================================
- Coverage 28.14% 28.13% -0.02%
==========================================
Files 2361 2362 +1
Lines 69846 69858 +12
Branches 13133 13134 +1
==========================================
- Hits 19660 19655 -5
- Misses 48629 48646 +17
Partials 1557 1557 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
shane-melton
requested changes
May 13, 2024
shane-melton
previously approved these changes
May 20, 2024
| @@ -778,11 +778,11 @@ export class CipherService implements CipherServiceAbstraction { | |||
| const response = await this.apiService.putCipherCollections(cipher.id, request); | |||
| // The response will be null when a Owner/Admin makes a request removing the last Can Manage Access | |||
There was a problem hiding this comment.
nit: We can update this comment since we're returning the new optional response model now and not null.
shane-melton
approved these changes
May 21, 2024
quexten
pushed a commit
that referenced
this pull request
May 22, 2024
…al Can Manage Collection of an item (#9136) * update saveCollectionsWithServer to accept a new value if user can no longer manage cipher after requested update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Previously when a user removed the final Can Manage collection of an item, the dialog would stay open and there was no indication that update was processed.
Now the collections dialog will close on save and the Cipher they no longer have access to will be removed from their list
Screen Recording
AC-2447-Last-Can-Manage-Removed.mov