Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7025] include check-run in workflows where secrets are used #9135

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bwdil
Copy link

@bwdil bwdil commented May 10, 2024

Type of change

GitHub workflows

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ X ] Other

Objective

As part of our organization-wide effort to secure bw code repos, a change to include check-run in workflows where secrets are used is required.

Code changes

Incremental change to existing workflows

@bwdil bwdil requested a review from a team as a code owner May 10, 2024 16:54
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.76%. Comparing base (4ae208f) to head (bb13e5d).

❗ Current head bb13e5d differs from pull request most recent head 3ac7bb8. Consider uploading reports for the commit 3ac7bb8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9135      +/-   ##
==========================================
- Coverage   27.76%   27.76%   -0.01%     
==========================================
  Files        2421     2421              
  Lines       70098    70097       -1     
  Branches    13059    13059              
==========================================
- Hits        19463    19462       -1     
  Misses      49123    49123              
  Partials     1512     1512              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 10, 2024

Logo
Checkmarx One – Scan Summary & Details522a9486-0e53-4118-b690-9ffa65f032ec

No New Or Fixed Issues Found

@bwdil bwdil requested a review from withinfocus May 10, 2024 17:31
@bwdil bwdil changed the title include check-run in workflows where secrets are used [PM-7025] include check-run in workflows where secrets are used May 10, 2024
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR wouldn't be necessary as-is; when you look at all the other workflows in this repo it might be. I would like to see one PR for the entire repo, as is relevant.

@@ -27,12 +27,18 @@ on:
- '.github/workflows/build-cli.yml'
workflow_dispatch:
inputs: {}
pull_request_target:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ You have to replace the above pull_request_target with this.

@@ -362,6 +368,7 @@ jobs:
- cli
- cli-windows
- snap
- check-run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ This is expanding the work surface but touches on something Oscar was bringing up -- needing secrets, and when. You'll see below that the secret reference is only relevant when on non-PR builds, so this check isn't even necessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, in that case we don't need check-run for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants