[PM-7926] Handle complex user logout events #9115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split up done logging out and navigation so we can always display expire warning.
MGibson1
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9115 +/- ##
==========================================
+ Coverage 27.70% 27.79% +0.08%
==========================================
Files 2418 2422 +4
Lines 70019 70266 +247
Branches 13052 13102 +50
==========================================
+ Hits 19401 19531 +130
- Misses 49106 49215 +109
- Partials 1512 1520 +8 ☔ View full report in Codecov by Sentry. |
|
Fixed Issues
|
apps/browser/src/platform/services/abstractions/abstract-chrome-storage-api.service.ts
Show resolved
Hide resolved
cagonzalezcs
previously approved these changes
May 10, 2024
Jingo88
previously approved these changes
May 10, 2024
jlf0dev
previously approved these changes
May 10, 2024
| // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling. | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| this.notificationsService.updateConnection(false); | ||
| void this.notificationsService.updateConnection(false); |
There was a problem hiding this comment.
nit: I'd feel a lot better if this had some error handling and an explanation.
MGibson1
dismissed stale reviews from jlf0dev, Jingo88, and cagonzalezcs
via
486a4f4
Send service does not currently support specified user data manipulation, so we ensure that the notification was sent to the active user prior to processing the notification.
cagonzalezcs
previously approved these changes
May 13, 2024
Jingo88
previously approved these changes
May 13, 2024
jlf0dev
previously approved these changes
May 13, 2024
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
MGibson1
dismissed stale reviews from jlf0dev, Jingo88, and cagonzalezcs
via
33666d4
justindbaur
approved these changes
May 14, 2024
Jingo88
approved these changes
May 14, 2024
jlf0dev
approved these changes
May 14, 2024
differsthecat
pushed a commit
that referenced
this pull request
May 14, 2024
* Update activity when switching users * Clear data of designated user * Do not switchMap to null, always to Promise or Observable * handle uninitialized popup services * Switch to new account immediately and log out as inactive. Split up done logging out and navigation so we can always display expire warning. * Do not navigate in account switcher, main.background takes care of it * Ignore storage updates from reseed events * Remove loading on cancelled logout * Catch missed account switch errors * Avoid usage of active user state in sync service Send service does not currently support specified user data manipulation, so we ensure that the notification was sent to the active user prior to processing the notification. * Clear sequentialize caches on account switch These caches are used to ensure that rapid calls to an async method are not repeated. However, the cached promises are valid only within a given userId context and must be cleared when that context changes. * Revert `void` promise for notification reconnect * Update libs/angular/src/services/jslib-services.module.ts Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com> * Handle switch account routing through messaging background -> app * Use account switch status to handle unlocked navigation case. * Revert "Handle switch account routing through messaging background -> app" This reverts commit 8f35078. --------- Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com> Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
eliykat
added a commit
that referenced
this pull request
May 14, 2024
eliykat
added a commit
that referenced
this pull request
May 15, 2024
* Create bit-cli folder with configs * Add bit-cli to workspace * Refactor CLI app structure * services are managed by the ServiceContainer * programs are registered by register(Oss|Bit)Program * the app is bootstrapped by Main * Reapply changes from #9099 * Reapply changes from #8604 * Reapply changes from #9115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This eneded up being a bit of a hodge-podge of fixing issues around logging our and nextup user determination.
"doneLoggingOut"removeandsaveevents that caused numerous race conditions on logout with components and services still usingfirstValueFrom. Ignoring events that don't match the signature of our storage services -- and therefore are special cases not due to the state provider framework -- resolves all the races I was seeing around logout.Code changes
Before you submit