Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8027] Inline menu appears within input fields that do not relate to user login #9110

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

cagonzalezcs
Copy link
Contributor

@cagonzalezcs cagonzalezcs commented May 9, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 9, 2024
@cagonzalezcs cagonzalezcs changed the title [PM-8027] Inlin menu appears within input fields that do not relate t… [PM-8027] Inlin menu appears within input fields that do not relate to user login May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

Logo
Checkmarx One – Scan Summary & Details8f93c74e-630b-4c51-99b3-530b93d09762

No New Or Fixed Issues Found

@cagonzalezcs cagonzalezcs changed the title [PM-8027] Inlin menu appears within input fields that do not relate to user login [PM-8027] Inline menu appears within input fields that do not relate to user login May 10, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 13.70968% with 107 lines in your changes are missing coverage. Please review.

Project coverage is 28.08%. Comparing base (f79d1da) to head (290fc6e).

Files Patch % Lines
...l/services/autofill-field-qualification.service.ts 10.08% 107 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9110      +/-   ##
==========================================
- Coverage   28.11%   28.08%   -0.03%     
==========================================
  Files        2395     2396       +1     
  Lines       70628    70749     +121     
  Branches    13208    13246      +38     
==========================================
+ Hits        19854    19868      +14     
- Misses      49200    49307     +107     
  Partials     1574     1574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant