Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The words "and complete two step login setup" are wrong #7084

Closed
jidanni opened this issue Nov 16, 2023 · 4 comments · Fixed by #9141
Closed

The words "and complete two step login setup" are wrong #7084

jidanni opened this issue Nov 16, 2023 · 4 comments · Fixed by #9141

Comments

@jidanni
Copy link

jidanni commented Nov 16, 2023

The words "and complete two-step login setup" are wrong.
20231116T085755
They should be "and complete two-step login, if any."

(Seen on the Low KDF iterations warning on https://vault.bitwarden.com/#/vault .)

@jidanni jidanni added the bug label Nov 16, 2023
@sammbw
Copy link

sammbw commented Nov 16, 2023

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

@Emmanu3l
Copy link

Emmanu3l commented Dec 1, 2023

@sammbw Hello! Is this still open? I would be interested in contributing to this.

@Emmanu3l
Copy link

Emmanu3l commented Dec 2, 2023

If so, could this issue be assigned to me? I have also noticed that the actual string in question appears to be in the "clients" repository, not in this repository.

@djsmith85 djsmith85 transferred this issue from bitwarden/server Dec 4, 2023
@djsmith85
Copy link
Contributor

Hi @Emmanu3l,

Thank you for offering your help with this. Github issues, don't get assigned, but feel free to open a Pull Request with your changes and link to this issue.

Please have a look at our Contribution Guidelines, these will help you with getting your environment set up and offer further information in regards to contributing.

Kind regards,
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants