Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix satoshisPerByte and remove '.value' from examples #98

Merged
merged 2 commits into from May 6, 2024

Conversation

bobbrodie
Copy link
Contributor

@bobbrodie bobbrodie commented Mar 16, 2024

Overview

This PR has two changes:

  • Fixing type on satoshisPerByte
  • Updating examples

Fixing type on satoshisPerByte

This is a new field that was defined as an int but needed to be updated to a float. I've tested this in a small project by pointing my pipfile to my branch.

Updating Examples

Our examples had:

client = Client.create_pos_client('somePosToken', Environment.TEST)

But that will throw an exception, so I've updated to:

client = Client.create_pos_client('somePosToken', Environment.TEST.value)

@bobbrodie bobbrodie changed the title Remove '.value' from examples Remove '.value' from examples and fix satoshisPerByte May 3, 2024
@bobbrodie bobbrodie linked an issue May 3, 2024 that may be closed by this pull request
@bobbrodie bobbrodie changed the title Remove '.value' from examples and fix satoshisPerByte Fix satoshisPerByte and remove '.value' from examples May 3, 2024
@bobbrodie bobbrodie merged commit 2ebabb3 into bitpay:6.0.x May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

satoshis_per_byte type in MinerFeesItem
2 participants