[REF] Add regtest support #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
testnetadvanced option when creating a wallet and it'll turn to regtest. This is particularly helpful when testing operations locally as several chains will fail address validation unless several manual changes are made after wallet creation (e.g. BCH & segwit addresses)This is PR related to and depends on bitpay/bitcore#3696. One must set
allowRegtestin their BWS config to allow the creation of regtest wallets.WIP: I've set this as a draft PR until the above bitcore PR is merged since this depends on it.