[Bitcore] Support Arb, Base, and Op Chains #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kajoseph
reviewed
Apr 30, 2024
kajoseph
requested changes
May 3, 2024
kajoseph
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Provides new chain support in BWS, BWC, and CWC
Add's streaming support to externally provided historical chain state.
Propositions
Token Suffix Standards
We will use the chain abbreviation as a token suffix as opposed to the first letter of the chain. So USDC on Arbitrum would be usdc_arb instead of usdc_a (i.e usdc_m for matic). This is to keep things easier to keep track as we adopt the increasing amount of chains.
Axios to replace request
Request has been deprecated for over three years. Axios is already being used by some dependencies and Insight. Axios also provides cleaner handling of responses. I propose Axios to be used all API requests this moving forward.
Chain != Coin
Bitcore (currently most prevalent in BWC) makes the assumption that a transactions coin would equal its chain. This is no longer true as more chains appear that utilize another coin as their gas token (i.e Optimism using ETH).