Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSK Integration #3427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ahsan-javaiid
Copy link

Description

  • This PR adds RSK integration into bitcore infrastructure
  • I did not make a copy of the ethereum implementation
  • Used a better approach to extend and override the ethereum classes
  • That means there will be almost zero maintenance cost for RSK and code will be easy to maintain.

Features

  • Integrated RSK into bitcore-node
  • Integrated RSK into bitcore-wallet-client
  • Integrated RSK into bitcore-wallet-service
  • Integrated RSK into crypto-wallet-core
  • Integrated RSK into crypto-rpc

Type of Change

  • New feature (Work in progress)

Bitpay-app Pull Requests

Test Plan

  • PR needs to be deployed on bitpay staging server along with rskj node
  • bitcore-node will start syncing (configurations below)
  • Change https://bws.bitpay.com/bws/api to deployed address in mobile app
  • Now test the RSK integration
  • Note: It can be tested only once bitcore-node sync process is complete

Update dependencies inside bitcore-node

  • For local testing or on staging server, bitcore-node dependences needs to include rsk integration as well
  • Use below commands as a reference
cp -r bitcore/packages/bitcore-wallet-client/ts_build bitcore/packages/bitcore-node/node_modules/bicore-wallet-client
cp -r bitcore/packages/crypto-wallet-core/ts_build bitcore/packages/bitcore-node/node_modules/crypto-wallet-core
cp -r crypto-rpc .bitcore/packages/bitcore-node/node_modules 

bitcore.config.json for RSK

{
  "bitcoreNode": {
    "chains": {
      "RSK": {
          "testnet": {
            "trustedPeers": [
              {
                  "host": "127.0.0.1",
                  "port": 4444
              }
            ],
            "chainSource": "p2p",
            "rpc": {
              "host": "127.0.0.1",
              "port": 4444,
              "username": "",
              "password": ""
            },
            "provider": {
              "protocol": "http",
              "host": "127.0.0.1",
              "port": 4444,
              "chain": "RSK"
            }
          }
        }
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant