This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Chore/cashaddr #826
Open
Chore/cashaddr #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiu
force-pushed
the
chore/cashaddr
branch
from
b82f301
to
925b856
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update BWS to use cashaddr internally
support old BWC clients, (address and txp creation with legacy
copayaddress for ok verification), by adding params to the now deprecated API endpoints.add entry points to new address & txp creation in
expressappfix error handling sockets notification
https://github.com/bitpay/bitcore-wallet-service/pull/826/files#diff-d0e088b0e4849ed8aec473d9e9aaf136R383
fix setAddress in getBalance (opts.coin no always set)
https://github.com/bitpay/bitcore-wallet-service/pull/826/files#diff-c945a46d13b34fcaff544d966cffcabaR1571