Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitcore-lib as a peerDependency #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CaptEmulation
Copy link

@CaptEmulation CaptEmulation commented Mar 25, 2017

One wrinkle to using the bitcore stack is the obvious need to have a singleton bitcore-lib. The bitcoin-lib package hosts the bitcoind library and there are good reasons to not wanting to have multiple bitcoind instances running on the same machine.

However, I am not a fan of the runtime check and would rather have all packages be declaring bitcoin-lib in peerDependencies. This way the enclosing package can specify whatever version of bitcoin-lib it wants and npm will inform user if there is an unmet dependency at install time rather than run time.

I have a working example of bitcore-lib running as a peerDependency at bitcore-docker-build which is also running testnet at bitcore.soapbubble.online/insight

I also updated bitcore-lib to 0.14 because bitcore-wallet-service has already done so and I figured if it was good enough for bitcoin-wallet-service it's good enough for everything else 馃槃

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2c09ad7 on CaptEmulation:bitcore-lib-as-peer-depdency into 98a5431 on bitpay:master.

@CaptEmulation
Copy link
Author

well from a Travis CI perspective I certainly see the flaw in my plan

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c090e45 on CaptEmulation:bitcore-lib-as-peer-depdency into 98a5431 on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c367194 on CaptEmulation:bitcore-lib-as-peer-depdency into 98a5431 on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b2347d0 on CaptEmulation:bitcore-lib-as-peer-depdency into 98a5431 on bitpay:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants