RN Changes 4 #740
RN Changes 4 #740
Conversation
| data: State[] | undefined | ||
| error: Error | undefined | ||
| isPending: boolean |
There was a problem hiding this comment.
Why this change? They’re in alphabetical order right now and that’s nice for scanning property names.
There was a problem hiding this comment.
Except for very long lists, I don't find alphabetical a very useful way to organize things. I usually order things by when are used, how often they're needed, the value they bring, etc. In this case: isPending is metadata about the rest of the items. (If there was a status, I'd put it first since isPending is derived from it.) `It will also be needed more frequently than the other two.
| readonly GOOGLE_OAUTH_CLIENT_ID: string | ||
| readonly GOOGLE_MAPS_API_KEY: string |
There was a problem hiding this comment.
Same here, why this change? Alphabetical order is always nice for quickly scanning.
There was a problem hiding this comment.
For trainings, I also sorting things in the order they're introduced to the audience. Besides making it clearer where they will put things or where to look in solutions, it also improves the quality an cleanliness of diffs (in general, but even moreso with the academy diff algorithm). (The diffing doesn't apply to this line, it explains the changes in several files in the last PR.)
No description provided.