Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/airflow] Ensure Airflow configuration values starting with dashes are set correctly #66535

Merged
merged 1 commit into from May 13, 2024

Conversation

zanecodes
Copy link
Contributor

Description of the change

This change fixes #65197 by passing the --value flag and its argument as a single string (i.e. "--value=$value", rather than --value "$value") to the ini-file tool.

Benefits

AIRFLOW_ configuration values that are added to airflow.cfg may now start with dashes, and the Airflow container will handle them correctly instead of erroring out on startup.

Applicable issues

@github-actions github-actions bot added the triage Triage is needed label May 9, 2024
@github-actions github-actions bot requested a review from javsalgar May 9, 2024 21:22
…vertently interpreted as additional argument names by the ini-file tool

Signed-off-by: Zane Geiger <me@zane.codes>
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.
LGTM

@rafariossaa rafariossaa merged commit 8f68d2d into bitnami:main May 13, 2024
37 checks passed
@rafariossaa
Copy link
Contributor

Our CI/CD will create and publish a new image that includes this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow airflow-scheduler airflow-worker solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/airflow] Airflow container errors out if AIRFLOW_FERNET_KEY or AIRFLOW_SECRET_KEY start with a dash
5 participants