Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/mongodb] journal doesnt work anymore since 6.1 #65826

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[bitnami/mongodb] journal doesnt work anymore since 6.1 #65826

wants to merge 1 commit into from

Conversation

Xyvran
Copy link

@Xyvran Xyvran commented May 2, 2024 •
edited by carrodher

@Xyvran
journal doesnt work anymore
7059f88 
Signed-off-by: Xyvran <18017491+Xyvran@users.noreply.github.com>
@github-actions github-actions bot added mongodb triage Triage is needed labels May 2, 2024
@github-actions github-actions bot requested a review from javsalgar May 2, 2024 16:01
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 3, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 3, 2024
@github-actions github-actions bot removed the request for review from javsalgar May 3, 2024 07:05
@github-actions github-actions bot requested a review from andresbono May 3, 2024 07:05
@andresbono andresbono changed the title journal doesnt work anymore since 6.1 [bitnami/mongodb] journal doesnt work anymore since 6.1 May 13, 2024
@andresbono
Copy link
Member

Hi, thank you for proposing this fix. I have some questions and comments:

  • How can I reproduce the issue? Although the setting you are removing is actually deprecated as per the info from #50109, is the application failing in some way when setting it? For compatibility with other old versions of MongoDB, it may be convenient to leave it there.
  • In case we agree with proceeding with the removal of this setting, shouldn't we go further with the changes are remove the references for that journal configuration and remove the env-var MONGODB_DEFAULT_ENABLE_JOURNAL and also apply the same changes for mongodb-sharded? The chart is also using this setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresbono andresbono Awaiting requested review from andresbono

At least 1 approving review is required to merge this pull request.

Assignees

@andresbono andresbono

Labels
in-progress mongodb verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/mongodb-sharded] Unrecognized option: storage.journal.enabled when starting mongodb
4 participants
@Xyvran @andresbono @javsalgar @carrodher