[bitnami/magento] add OpenSearch as a search engine option #63946
Conversation
Signed-off-by: vtkstef <stefano.santoro@toasttab.com>
carrodher
added
verify
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
@carrodher FYI can you please reset the timer on this PR. Thanks |
|
We are going to review this logic internally and we will notify you in this PR when there is any news. |
|
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
|
Ping @mdhont |
carrodher
added
in-progress
and removed
stale
| # Define whether Opensearch auth is enabled | ||
| local oss_auth="0" | ||
| is_boolean_yes "$MAGENTO_OPENSEARCH_ENABLE_AUTH" && oss_auth="1" | ||
| # Elasticsearch configuration is stored in the database, so we only need to specify for 'setup:install' |
There was a problem hiding this comment.
| # Elasticsearch configuration is stored in the database, so we only need to specify for 'setup:install' | |
| # OpenSearch configuration is stored in the database, so we only need to specify for 'setup:install' |
| @@ -228,6 +265,10 @@ magento_initialize() { | |||
| info "Trying to connect to Elasticsearch" | |||
| magento_wait_for_es_connection "$es_host" "$es_port" | |||
| fi | |||
| if [[ "$MAGENTO_SEARCH_ENGINE" =~ ^opensearch ]]; then | |||
| info "Trying to connect to Opensearch" | |||
| magento_wait_for_es_connection "$oss_host" "$oss_port" | |||
There was a problem hiding this comment.
I would rename this function to something generic. E.g. magento_wait_for_search_engine_connection or similar.
| if [[ "$MAGENTO_SEARCH_ENGINE" =~ ^opensearch ]]; then | ||
| oss_host="$MAGENTO_OPENSEARCH_HOST" | ||
| oss_port="$MAGENTO_OPENSEARCH_PORT_NUMBER" | ||
| info "Trying to connect to Elasticsearch" |
There was a problem hiding this comment.
| info "Trying to connect to Elasticsearch" | |
| info "Trying to connect to OpenSearch" |
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Description of the change
add OpenSearch as a search engine option for Magento. Option
ealasticsearch5andelasticsearch6areno longer supported during setup/bootstrap in magento 2.4.6
Benefits
OpenSearch has a more permissive open source license (hence the fork from elastic search by amazon)
Possible drawbacks
n/a
Applicable issues
Additional information
Option
ealasticsearch5andelasticsearch6areno longer supported during setup/bootstrap in magento 2.4.6