Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/airflow] Add libraries libpq-dev python-dev gcc to support installation psycopg2 as dependency #48258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oktayalizada
Copy link

Description of the change

The change introduces three new packages which will be installed in airflow pods to support installation of psycopg2 library from requirements.txt file.
Currently if we add psycopg2 library to requirements.txt we will get an error:
Error: pg_config executable not found.

Benefits

Possibility to use bitnami images and helm chart to install psycopg2 and other libraries which depend on it

Applicable issues

@bitnami-bot bitnami-bot added this to Triage in Support Sep 12, 2023
@github-actions github-actions bot added the triage Triage is needed label Sep 12, 2023
…g2 as dependency

Signed-off-by: oktay <oktay@alizada.net>
@javsalgar javsalgar changed the title Add libraries libpq-dev python-dev gcc to support installation psycopg2 as dependency [bitnami/airflow] Add libraries libpq-dev python-dev gcc to support installation psycopg2 as dependency Sep 13, 2023
@javsalgar javsalgar moved this from Triage to In progress in Support Sep 13, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Sep 13, 2023
@bitnami-bot bitnami-bot removed the request for review from javsalgar September 13, 2023 10:25
@fevisera
Copy link
Contributor

fevisera commented Sep 28, 2023

Hi @oktayalizada,

I have built the image locally, and it appears to be quite large:

local/airflow                   latest                        5bc6e03c8bf9   14 minutes ago   3.28GB 
bitnami/airflow                 latest                        8255c5199bb5   3 days ago       1.77GB

I believe the intention in bitnami/charts#19242 was to create a fork rather than modify the bitnami airflow images. Adding these additional packages would need additional analysis, including an assessment of image size and the need for these packages. For instance, adding python-dev may include more packages than necessary.

Please let me know if there are any additional details I may be overlooking.

@github-actions github-actions bot moved this from In progress to Pending in Support Sep 28, 2023
@oktayalizada
Copy link
Author

Hi @fevisera,
So you mean airflow will not support installation and usage of psycopg2 library in airflow pods? Can we have maybe a different tag for this specific build (e.g. debian-11-psycopg2)?

@github-actions github-actions bot moved this from Pending to In progress in Support Sep 29, 2023
@fevisera
Copy link
Contributor

fevisera commented Oct 3, 2023

Hi @oktayalizada,

Thank you for your question! I did not mean to imply that Airflow will not support the installation and usage of the psycopg2 library for bitnami/airflow. What I intended to convey is that before adding those new packages, it is essential to conduct a more thorough analysis to assess the image size impact and the actual necessity of these packages.

We already have an ongoing internal task to address adding dependencies feature, which has been created for #48258. As soon as this functionality becomes available, we will notify you here.

Thank you for proposing this change and bringing it to our attention. If you have any more questions or concerns, please feel free to ask. We appreciate your feedback.

@github-actions github-actions bot moved this from In progress to Pending in Support Oct 3, 2023
@fevisera fevisera added the on-hold Issues or Pull Requests with this label will never be considered stale label Oct 3, 2023
@fevisera fevisera moved this from Pending to On hold in Support Oct 3, 2023
@carrodher carrodher removed the request for review from fevisera April 22, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow on-hold Issues or Pull Requests with this label will never be considered stale
Projects
No open projects
Support
On hold
Development

Successfully merging this pull request may close these issues.

None yet

4 participants