Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/thanos] Receive, ruler & storegateway statefulsets persistentVolumeClaimRetentionPolicy support #25676

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

clarifai-fmarceau
Copy link

@clarifai-fmarceau clarifai-fmarceau commented May 10, 2024

Description of the change

These changes add persistentVolumeClaimRetentionPolicy support to statefulsets of the Thanos Helm chart.

Benefits

We can now set persistentVolumeClaimRetentionPolicy.whenScaled & persistentVolumeClaimRetentionPolicy.whenDeleted for Ruler, Receive & Store Gateway individually.

Possible drawbacks

None, the change is feature flagged and if enabled the defaults are aligned with the Kubernetes ones.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added thanos triage Triage is needed labels May 10, 2024
@github-actions github-actions bot requested a review from javsalgar May 10, 2024 15:29
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@clarifai-fmarceau
Copy link
Author

clarifai-fmarceau commented May 13, 2024

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

Just signed an empty commit in my fork's branch, is that enough !? I'm sorry about that, I thought that having my commits signed on Github directly was it/ was enough.

@carrodher
Copy link
Member

It seems it's not enough since the DCO action is still failing. Here you can see the details and how to fix the issue.

bitnami-bot and others added 5 commits May 13, 2024 10:07
…tnami#25672)

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Francois Marceau <francois.marceau@clarifai.com>
…tVolumeClaimRetentionPolicy support

Signed-off-by: Francois Marceau <francois.marceau@clarifai.com>
Signed-off-by: Francois Marceau <francois.marceau@clarifai.com>
Signed-off-by: Francois Marceau <francois.marceau@clarifai.com>
Signed-off-by: Francois Marceau <francois.marceau@clarifai.com>
@clarifai-fmarceau clarifai-fmarceau force-pushed the thanos_persistentVolumeClaimRetentionPolicy branch from cca14c3 to 4517d7a Compare May 13, 2024 14:07
Signed-off-by: François Marceau <108883925+clarifai-fmarceau@users.noreply.github.com>
@clarifai-fmarceau
Copy link
Author

clarifai-fmarceau commented May 13, 2024

Thank you for pointing me to that! Done, signed off every commit.

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 13, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 13, 2024
@github-actions github-actions bot removed the request for review from javsalgar May 13, 2024 14:20
@github-actions github-actions bot requested a review from juan131 May 13, 2024 14:20
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution! Please ensure you merge latest changes from main branch and resolve the conflicts.

Also, please note the PersistentVolumeClaim retention was included in Kubernetes 1.23 and therefore, we should include take it into account introducing the safeguard below:

{{- if semverCompare ">=1.23-0" (include "common.capabilities.kubeVersion" .) -}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress thanos verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/thanos] Statefulsets persistentVolumeClaimRetentionPolicy support
5 participants