Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitnami/external-dns: Templatize Domain Filters/Exclusions #25603

Merged
merged 3 commits into from May 13, 2024

Conversation

seanblong
Copy link
Contributor

Description of the change

Leverage the helper function, common.tplvalues.render, for domain filters and exclusions.

Benefits

For our particular use case, we're building ephemeral clusters where the cluster name becomes part of the subdomain requirement. We'd like the ability to parameterize the input to make the Helm chart a little easier to use by reducing number of overrides.

Possible drawbacks

N/A

Applicable issues

N/A

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Sean Blong <seanblong@gmail.com>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 8, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 8, 2024
@github-actions github-actions bot removed the request for review from carrodher May 8, 2024 05:52
@github-actions github-actions bot requested a review from andresbono May 8, 2024 05:53
Signed-off-by: Andrés Bono <andresbono@vmware.com>
Copy link
Member

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!!

@andresbono andresbono enabled auto-merge (squash) May 13, 2024 09:52
@andresbono andresbono merged commit 1b54f77 into bitnami:main May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dns solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants