bitnami/mongodb: Allow labels for volumeClaimTemplates #25571
Conversation
carrodher
added
verify
There was a problem hiding this comment.
Hi @jbertozzi
Thanks for contributing. Could you take a look at my comments?
bitnami/mongodb/Chart.yaml
Outdated
| @@ -39,4 +39,4 @@ maintainers: | |||
| name: mongodb | |||
| sources: | |||
| - https://github.com/bitnami/charts/tree/main/bitnami/mongodb | |||
| version: 15.1.7 | |||
| version: 15.1.8 | |||
There was a problem hiding this comment.
Bump a minor version when adding new values --> 15.2.0
There was a problem hiding this comment.
Hi @dgomezleon,
I have updated the version accordingly.
| {{- if or .Values.commonLabels .Values.sentinel.labels }} | ||
| {{- $annotations := include "common.tplvalues.merge" ( dict "values" ( list .Values.sentinel.labels .Values.commonLabels ) "context" . ) }} | ||
| labels: {{- include "common.tplvalues.render" ( dict "value" $labels "context" $) | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Could you please add this in a separate diff bumping Redis version?
There was a problem hiding this comment.
I have removed this chunk, I will open a dedicated PR for redis.
|
Hi @jbertozzi , |
…5678) Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Jérémy Bertozzi <jeremy.bertozzi@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Jérémy Bertozzi <jeremy.bertozzi@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Jérémy Bertozzi <jeremy.bertozzi@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Jérémy Bertozzi <jeremy.bertozzi@gmail.com>
Signed-off-by: Jérémy Bertozzi <jeremy.bertozzi@gmail.com>
Signed-off-by: jbertozzi <jeremy.bertozzi@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Hi @dgomezleon, Sorry about that, it should be ok now. Thanks for your time. |
Description of the change
This commit add consistency with others bitnami charts (i.e.: postgresql) by adding a new parameter (.persistence.labels).
Benefits
More flexibility for end user.
Possible drawbacks
No drawbacks.
Additional information
Some context: we have some kyverno policy that force end user to put a label on their pvc to specify explicitly whether they want a backup or not. This patch to fix this.
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm