Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/postgresql] Allow loadBalancerClass to be customized #25569

Merged
merged 5 commits into from May 13, 2024
Merged

[bitnami/postgresql] Allow loadBalancerClass to be customized #25569

merged 5 commits into from May 13, 2024

Conversation

jamezrin
Copy link
Contributor

@jamezrin jamezrin commented May 6, 2024

Description of the change

This PR allows the loadBalancerClass to be customized via the chart values in the postgresql chart.

Benefits

Allows the following values to be set, setting the loadBalancerClass to be set in the respective Service

  • primary.service.loadBalancerClass
  • readReplicas.service.loadBalancerClass

Possible drawbacks

None

Applicable issues

None

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added postgresql triage Triage is needed labels May 6, 2024
@github-actions github-actions bot requested a review from carrodher May 6, 2024 20:24
jamezrin and others added 3 commits May 6, 2024 22:25
@jamezrin
feat: add loadBalancerClass field
1e49c32 
Signed-off-by: Jaime Martínez Rincón <jaime@jamezrin.name>
@jamezrin
chore: bump version
4db7d76 
Signed-off-by: Jaime Martínez Rincón <jaime@jamezrin.name>
@bitnami-bot @jamezrin
Update README.md with readme-generator-for-helm
add3e83 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Jaime Martínez Rincón <jaime@jamezrin.name>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 7, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 7, 2024
@github-actions github-actions bot removed the request for review from carrodher May 7, 2024 09:45
@github-actions github-actions bot requested a review from andresbono May 7, 2024 09:45
@andresbono
Merge branch 'main' into main
7c3b41d 
Signed-off-by: Andrés Bono <andresbono@vmware.com>
@andresbono
Update Chart.yaml
1430ae2 
Signed-off-by: Andrés Bono <andresbono@vmware.com>
andresbono
andresbono approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for your contribution

@andresbono andresbono enabled auto-merge (squash) May 13, 2024 08:38
@andresbono andresbono merged commit e6fecf9 into bitnami:main May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresbono andresbono andresbono approved these changes

Assignees

@andresbono andresbono

Labels
postgresql solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jamezrin @andresbono @carrodher @bitnami-bot