New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql] Allow backup pod to use DNS #25534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrodher
added
verify
Execute verification workflow for these changes
in-progress
labels
May 6, 2024
Signed-off-by: Aaron Reisman <aaron@reisman.org>
Signed-off-by: Aaron Reisman <aaron@reisman.org>
need it, please merge it, thanks |
I’m ready to merge it as soon as @carrodher approves it. |
Signed-off-by: Andrés Bono <andresbono@vmware.com>
andresbono
previously approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you so much for your contribution!
Signed-off-by: Andrés Bono <andresbono@vmware.com>
andresbono
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Allows the backup pod to use DNS which it requires to resolve the service it's backing up.
Benefits
Allows backups to work when storing the password as an environment variable
Possible drawbacks
None
Applicable issues
Additional information
Backups are still broken when storing passwords in files
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm