Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql] Allow backup pod to use DNS #25534

Merged
merged 4 commits into from May 13, 2024
Merged

Conversation

pixil98
Copy link
Contributor

@pixil98 pixil98 commented May 5, 2024

Description of the change

Allows the backup pod to use DNS which it requires to resolve the service it's backing up.

Benefits

Allows backups to work when storing the password as an environment variable

Possible drawbacks

None

Applicable issues

Additional information

Backups are still broken when storing passwords in files

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added postgresql triage Triage is needed labels May 5, 2024
@github-actions github-actions bot requested a review from carrodher May 5, 2024 05:02
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 6, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 6, 2024
@github-actions github-actions bot removed the request for review from carrodher May 6, 2024 06:15
@github-actions github-actions bot requested a review from andresbono May 6, 2024 06:15
Signed-off-by: Aaron Reisman <aaron@reisman.org>
Signed-off-by: Aaron Reisman <aaron@reisman.org>
@colin719
Copy link
Contributor

need it, please merge it, thanks

@pixil98
Copy link
Contributor Author

pixil98 commented May 13, 2024

need it, please merge it, thanks

I’m ready to merge it as soon as @carrodher approves it.

Signed-off-by: Andrés Bono <andresbono@vmware.com>
andresbono
andresbono previously approved these changes May 13, 2024
Copy link
Member

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much for your contribution!

@andresbono andresbono enabled auto-merge (squash) May 13, 2024 07:56
@andresbono andresbono disabled auto-merge May 13, 2024 07:57
Signed-off-by: Andrés Bono <andresbono@vmware.com>
@andresbono andresbono enabled auto-merge (squash) May 13, 2024 07:59
@andresbono andresbono merged commit 960550a into bitnami:main May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postgresql solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql] Included networkpolicy blocks backup job from using dns
4 participants