Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/grafana-operator] Fixes the indentation for the auth subsections within config section. #25467

Merged
merged 3 commits into from May 13, 2024

Conversation

fabio-s-franco
Copy link
Contributor

Fixes a couple of links that were broken (outdaten).

Description of the change

Fixes indentation of commented-out auth sections that would error if attempted to use from the values file.
The changes have no direct impact as they only modify commented parts.

Fixed a couple of documentation reference links.

Benefits

Prevents user from having to debug the reason for the error when attempting to enable the auth examples.

Possible drawbacks

None

Applicable issues

Additional information

There may still be other broken (outdated) reference hyperlinks.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Fixes a couple of links that were broken (outdaten).

Signed-off-by: Fábio Franco <37698530+fabio-s-franco@users.noreply.github.com>
Signed-off-by: Andrés Bono <andresbono@vmware.com>
Signed-off-by: Andrés Bono <andresbono@vmware.com>
Copy link
Member

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much for your contribution!!

@andresbono andresbono enabled auto-merge (squash) May 13, 2024 06:58
@andresbono andresbono merged commit 9acd313 into bitnami:main May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grafana-operator solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/grafana-operator] spec.config.security.auth in body must be of type string: "object"
4 participants