New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/jenkins] Stabilize Jenkins by adding a replicaCount #25108
Conversation
Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com>
Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com>
Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com>
@chrira please check |
Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com>
Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com>
Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com>
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the implementation.
Please forget my initial idea with the complex logic for having it defined or not.
When needed the autoscaling feature could be added.
In this PR I would just add the replicaCount with a fix number of 1.
Hi! Thank you so much for the PR! Could you bump the chart version? |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com>
Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com>
There are some failing actions:
You need to bump the chart version to properly release a new Helm chart with those changes |
Signed-off-by: Raphaela Seeger <elatella@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and is aligned with other bitnami charts.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: David Gomez <dgomezleon@vmware.com>
…#25108) * Add replicaCount to values Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com> * Add replicCount to deployment.yaml Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com> * Add replicaCount to README.md Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com> * Update replicaCount to {} in values.yaml Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com> * Update deployment.yaml Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com> * Update values.yaml Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com> * Simplify ReplicaCount Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com> * Simplify replica solution Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com> * Update ReadMe and Bump version Signed-off-by: Raphaela Seeger <elatella@users.noreply.github.com> --------- Signed-off-by: Raphaela <44403256+elatella@users.noreply.github.com> Signed-off-by: Raphaela Seeger <elatella@users.noreply.github.com> Signed-off-by: David Gomez <dgomezleon@vmware.com> Co-authored-by: Raphaela Seeger <elatella@users.noreply.github.com> Co-authored-by: David Gomez <dgomezleon@vmware.com> Signed-off-by: Fran Mulero <fmulero@vmware.com>
Description of the change
Add replicaCount to declare replicaCout in Values
Benefits
By declaring the replicaCount, it removes the possibility to have the replicas scaled up or down my external applications (ArgoCD, ...)
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm