Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/milvus] Fix milvus config #21013

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[bitnami/milvus] Fix milvus config #21013

wants to merge 6 commits into from

Conversation

rafariossaa
Copy link
Contributor

Description of the change

Milvus 2.3.x needs a config file for the log

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@rafariossaa
[bitnami/milvus] Adds log config
b8efb8a 
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
@rafariossaa
Updates chart version and README
0fb6d74 
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
@bitnami-bot bitnami-bot added this to From Bitnami in Support Nov 16, 2023
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Nov 16, 2023
@rafariossaa
Removes unneeded files
1a724df 
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
migruiz4
migruiz4 reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@migruiz4 migruiz4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion

bitnami/milvus/templates/_helpers.tpl Outdated Show resolved Hide resolved
@rafariossaa @migruiz4
Update bitnami/milvus/templates/_helpers.tpl
4b91895 
Co-authored-by: Miguel Ruiz <miruiz@vmware.com>
Signed-off-by: Rafael Ríos Saavedra <rafael.rios.saavedra@gmail.com>
migruiz4
migruiz4 reviewed Nov 17, 2023
View reviewed changes
bitnami/milvus/Chart.yaml Outdated Show resolved Hide resolved
@rafariossaa
Push chart version
d6cb9fc 
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
javsalgar
javsalgar previously approved these changes Nov 17, 2023
View reviewed changes
@rafariossaa
Merge branch 'main' into fix_milvus_config
530d59c 
Signed-off-by: Rafael Ríos Saavedra <rrios@vmware.com>
@Uijeong97
Copy link
Contributor

@rafariossaa @migruiz4 @javsalgar

Is this PR still under review?
I'm trying to use version 2.3.x, but I don't have the glog.conf file mentioned in the above PR.
Would it be possible for you to review and merge the PR?

@github-actions github-actions bot assigned joancafom and unassigned migruiz4 Dec 4, 2023
@joancafom joancafom assigned rafariossaa and unassigned joancafom Dec 5, 2023
Uijeong97
Uijeong97 reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@Uijeong97 Uijeong97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it on 2.3.3 and it deployed well 😆

@rafariossaa
Copy link
Contributor Author

Hi,
Yes, we are waiting for next release of milvus, as we are currently experiencing some issues in our CI/CD when building the current version.

@rafariossaa rafariossaa added on-hold Issues or Pull Requests with this label will never be considered stale and removed in-progress labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uijeong97 Uijeong97 Uijeong97 approved these changes

@migruiz4 migruiz4 migruiz4 approved these changes

@javsalgar javsalgar javsalgar left review comments

@joancafom joancafom Awaiting requested review from joancafom

Assignees

@rafariossaa rafariossaa

Labels
bitnami milvus on-hold Issues or Pull Requests with this label will never be considered stale verify Execute verification workflow for these changes
Projects
No open projects
Support
From Bitnami
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rafariossaa @Uijeong97 @javsalgar @migruiz4 @bitnami-bot @joancafom