Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/thanos] Statefulsets persistentVolumeClaimRetentionPolicy support #25339

Closed
clarifai-fmarceau opened this issue Apr 23, 2024 · 5 comments · May be fixed by #25676
Closed

[bitnami/thanos] Statefulsets persistentVolumeClaimRetentionPolicy support #25339

clarifai-fmarceau opened this issue Apr 23, 2024 · 5 comments · May be fixed by #25676
Assignees
@javsalgar
Labels
feature-request solved stale 15 days without activity thanos triage Triage is needed

Comments

@clarifai-fmarceau
Copy link

Name and Version

bitnami/thanos 15.2.1

What is the problem this feature will solve?

It'll solve the lack of support for persistentVolumeClaimRetentionPolicy on statefulsets.

What is the feature you are proposing to solve the problem?

Implement support for persistentVolumeClaimRetentionPolicy in statefulset resources just like it has already been done for other charts in this repo.

What alternatives have you considered?

Using my own fork of the chart until this is addressed.
@github-actions github-actions bot added the triage Triage is needed label Apr 23, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the feature request. I will forward it to the team but as it is not a critical issue we cannot guarantee an ETA. If you want to speed up the process, would you like to submit the changes in your fork via PR?

@github-actions GitHub Actions
Copy link

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label May 10, 2024
@clarifai-fmarceau clarifai-fmarceau mentioned this issue May 10, 2024
Open
4 tasks
@clarifai-fmarceau
Copy link
Author

Made a PR for that.

@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

@github-actions GitHub Actions
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javsalgar javsalgar

Labels
feature-request solved stale 15 days without activity thanos triage Triage is needed
Projects
None yet
Milestone
No milestone
4 participants
@javsalgar @bitnami-bot @carrodher @clarifai-fmarceau