Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing problem with Representation Base #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmunozpoveda
Copy link

There is a problem storing concrete objects and returning interfaces.
Right way is store directly the interface in the class

Representation Base has to store Interfaces, if not when you access…
@jmunozpoveda
Copy link
Author

@msmole @schellkenig @slederer
Could you take a look to this PR?
I was trying to know if a Adaptation set had TrickModes. So I had to check GetRepresentations and then get GeSchemeIdUri, but accessing to this string I was getting a segmentation fault. The root cause is the explanied y my previous comment, IRepresentationBase has to store the interfaces instead of the explicit class and then casting to interface.

BTW: From Telefonica Team we have done another MR, one fixing the problem with Qt sample due to a old ffmpeg version, and another one fixing a problem in functionn BlockQueuePeekBytes. It would be great if you can merge/review this things.

BR, Julian

@zenzi-deluxe
Copy link
Collaborator

Hi @jmunozpoveda, thank you for opening this PR. Could you provide more information regarding the manifest you are using so that we can test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants