New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guix: fix suggested fake date for openssl-1.1.1l #29999
base: master
Are you sure you want to change the base?
Conversation
Also fix layout of instructions.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
cc @dongcarl |
Changing the system date is a terrible workaround in any case imo. Is there really no other way? |
@laanwj I believe newer versions of OpenSSL have more robust tests, but we don't want to bump our Guix Time Machine commit just for that. |
If I remember correctly, I think that you can likely just patch OpenSSL here since it's not a package that is "core" to Guix like GnuTLS was? |
I wrote:
Actually our Time Machine commit is much more recent than I thought. Will defer to @dongcarl. |
I presume openssl is used in the bootstrap chain, to bootstrap older software, so it probably can never be removed in a time machine bump? |
Yes, this is workaround 3, added in fad444f.
|
We already have that recommendation, but I think it's better to offer an alternative. "Don't worry about tests not passing" is something I prefer to only do when I really understand how everything works, which I don't. |
Is it possible to use a UTS namespace to spoof the clock just for the build? |
Using
2020-10-01
as the fake timestamp will cause many test failures with/gnu/store/bfirgq65ndhf63nn4q6vlkbha9zd931q-openssl-1.1.1l.drv
. I didn't investigate why, but I guess because it's before the test certificates were created. They expired in June 2022. I tried a month before that, which worked.Also fixes layout of instructions.