Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial]: Correct spellings across bips #675

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Conversation

Varunram
Copy link
Contributor

No description provided.

@practicalswift
Copy link

ACK 333a605

@luke-jr
Copy link
Member

luke-jr commented May 20, 2018

BIP 35: @jgarzik
BIP 60: @genjix
BIPs 11, 16, 61: @gavinandresen
BIPs 80 & 81: @justusranvier @jimmysong
BIPs 98, 116, 117: @maaku @kallewoof @btcdrak
BIP 143: @jl2012 @sipa
BIP 152: @TheBlueMatt
BIP 157: @Roasbeef @aakselrod @jimpo
BIP 158: @Roasbeef @aakselrod
BIP 174: @achow101
BIP 176: @jimmysong

@practicalswift Why did you ACK this? You don't seem to be an author for any of the BIPs? O.o

@practicalswift
Copy link

practicalswift commented May 20, 2018

@luke-jr I wasn't aware that only BIP authors were supposed to review typo fixes. Sorry about that! :-)

@luke-jr
Copy link
Member

luke-jr commented May 20, 2018

Yes, it's kind of a nuisance. I opened #596 a while back, but got push-back on the mailing list. :(

@jimpo
Copy link
Contributor

jimpo commented May 20, 2018

ACK BIP 157

@sipa
Copy link
Member

sipa commented May 20, 2018

ACK BIP 143

@kallewoof
Copy link
Member

ACK BIP 98, 116, 117.

@gavinandresen
Copy link
Contributor

gavinandresen commented May 21, 2018 via email

@Varunram
Copy link
Contributor Author

ping @luke-jr, can I edit the PR just to include the BIPs which have been ACKed?

@luke-jr
Copy link
Member

luke-jr commented Jun 20, 2018

Please don't. That would reset the ACKs. I'll manually merge the applicable ones when I get a chance.

@luke-jr
Copy link
Member

luke-jr commented Jul 5, 2018

Merged BIPs 11, 16, 61, 98, 116, 117, 143, 157 in c3e8379

Leaving open for the remaining BIPs (please don't rebase)

@jbampton jbampton mentioned this pull request May 7, 2021
@jgarzik
Copy link
Contributor

jgarzik commented Feb 16, 2024

ACK, for my small part

Copy link
Contributor

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing against master, it appears that only four typos remain unfixed:

BIP 35: desireable ↦ desirable
BIP 80: signfigant ↦ significant
BIP 81: signfigant ↦ significant
BIP 174: compatibilty ↦ compatibility

The merge-conflict appears to be due to another typo fix that got merged since this PR got opened. Given typos may be fixed now, I’m gonna merge this.

@murchandamus murchandamus merged commit 2d9e431 into bitcoin:master Apr 30, 2024
3 checks passed
@murchandamus
Copy link
Contributor

I made a mistake in resolving the merge conflict with BIP-0176 and had to revert the change in another commit to avoid force pushing. I squashed the remaining for typos into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants