-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[trivial]: Correct spellings across bips #675
Conversation
ACK 333a605 |
BIP 35: @jgarzik @practicalswift Why did you ACK this? You don't seem to be an author for any of the BIPs? O.o |
@luke-jr I wasn't aware that only BIP authors were supposed to review typo fixes. Sorry about that! :-) |
Yes, it's kind of a nuisance. I opened #596 a while back, but got push-back on the mailing list. :( |
ACK BIP 157 |
ACK BIP 143 |
ACK BIP 98, 116, 117. |
Perpetual ACK for all trivial changes that do not change the meaning of BIPs I wrote.
|
ping @luke-jr, can I edit the PR just to include the BIPs which have been ACKed? |
Please don't. That would reset the ACKs. I'll manually merge the applicable ones when I get a chance. |
Merged BIPs 11, 16, 61, 98, 116, 117, 143, 157 in c3e8379 Leaving open for the remaining BIPs (please don't rebase) |
ACK, for my small part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing against master, it appears that only four typos remain unfixed:
BIP 35: desireable ↦ desirable
BIP 80: signfigant ↦ significant
BIP 81: signfigant ↦ significant
BIP 174: compatibilty ↦ compatibility
The merge-conflict appears to be due to another typo fix that got merged since this PR got opened. Given typos may be fixed now, I’m gonna merge this.
I made a mistake in resolving the merge conflict with BIP-0176 and had to revert the change in another commit to avoid force pushing. I squashed the remaining for typos into master. |
No description provided.