Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP38, help GitHub intermediate syntax highlighter #1586

Merged
merged 2 commits into from
May 8, 2024

Conversation

katesalazar
Copy link
Contributor

It seems GitHub has some problem interpreting quintuple single quotes on the blame and styles-enriched-raw renderings.

Edited using the browser, pending rebase and fixup.

@katesalazar
Copy link
Contributor Author

I'd prefer reporting upstream before here, but IDK how.

@murchandamus
Copy link
Contributor

I understand the first change where you add the missing double single quotes to close the italicized phrase, but it’s not clear to me what problem this generally solves, since the before and after render the same for me. Could you clarify your motivation for this PR?

@katesalazar
Copy link
Contributor Author

Yeah, I actually thought about adding some screenshots. 😅

First try to find something wrong here:

2024-05-06_19-09

If you were able to find something wrong in the previous figure, then try to find a fix here:

2024-05-06_19-10

@murchandamus
Copy link
Contributor

I see. I didn’t notice that the Specification section was italicized before.

@murchandamus
Copy link
Contributor

Okay, please feel free to ping me for review when this is ready to be merged.

Add missing closing double single quote. The italicized paragraph gets
cautiously closed.
Separating the bold and the italic markup helps inconsistent parsing
(see screenshots in PR bitcoin#1586).
@katesalazar katesalazar marked this pull request as ready for review May 7, 2024 15:57
@katesalazar
Copy link
Contributor Author

Waiting for further feedback,
I see no urgency justifying pinging.

@murchandamus
Copy link
Contributor

This fixes a minor formatting issue that appears in the GitHub online editor with quintuple quotes and closes an italicized phrase by adding the missing closing symbol.

@murchandamus murchandamus merged commit 690f70c into bitcoin:master May 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants