ci: Fix link checks #1585
Merged
ci: Fix link checks #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link format CI check is currently silently failing, for example https://github.com/bitcoin/bips/actions/runs/8914643431/job/24482636376.
This failure is caused by Github Actions cloning as little as possible for CI, so the git commands in the script end up failing. This checkout was done in order to check current PRs, however, it's not much more expensive nor onerous to just always check the links in the entire repo, and would allow this check to actually work. This PR does that, and also fixes the broken link formats in BIPs 197 and 310.