Fix misleading signmessage error with segwit #819
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
willcl-ark
force-pushed
the
signmessage-error-fix
branch
from
93c8252
to
83def1c
Compare
hebasto
changed the title
There was a problem hiding this comment.
Approach ACK 83def1c on the content of the messages.
However, splitting lines makes translation work harder due to providing less context. Could you make every touched message a single translatable string?
Also, if you'd like, add translation comment will be very useful to avoid any potential issue similar to (for example, https://github.com/bitcoin/bitcoin/commit/.
There was a problem hiding this comment.
And "Bitcoin Core" phrase should be replaced with PACKAGE_NAME (see bitcoin/bitcoin#18646, bitcoin/bitcoin#19282 etc).
willcl-ark
force-pushed
the
signmessage-error-fix
branch
from
83def1c
to
0fea73f
Compare
|
Hi @hebasto I took your suggestions save for the extra context comments -- I think the text as one blob like this is pretty self-explanatory? |
|
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the Possibly this is due to a silent merge conflict (the changes in this pull request being Leave a comment here, if you need help tracking down a confusing failure. |
willcl-ark
force-pushed
the
signmessage-error-fix
branch
from
0fea73f
to
8428fa3
Compare
|
Sorry, I've addressed the linter now. |
As described in #10542 (and numerous other places), message signing in Bitcoin Core only supports message signing using P2PKH addresses, at least until a new message-signing standard is agreed upon. Therefore update the possibly-misleading error message presented to the user in the GUI to detail more specifically the reason their message cannot be signed, in the case that a non P2PKH address is entered.
willcl-ark
force-pushed
the
signmessage-error-fix
branch
from
8428fa3
to
fb9f150
Compare
As described in bitcoin/bitcoin#10542 (and numerous other places), message signing in Bitcoin Core does not support "signing with a segwit address" and likely will not in the foreseeable future, or at least until a new message-signing standard is agreed upon.
Therefore update the possibly misleading error message presented to the user in the GUI to detail more specifically the reason their message cannot be signed, in the case that a non P2PKH address is entered.
This change takes the suggested wording from @adiabat.
Perhaps with this we can close bitcoin/bitcoin#10542 ?