Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biscuit v5 #217

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Biscuit v5 #217

wants to merge 11 commits into from

Conversation

Geal
Copy link
Contributor

@Geal Geal commented May 12, 2024

This PR holds the upcoming changes for the v5 format:

  • raise the minimum schema version to 5

set the block version when using 3rd party blocks
divarvel and others added 9 commits May 12, 2024 16:04
* feat: add `reject if`

This acts like the opposite of `check if`: if there is a match, then authorization fails.

Using `reject if` raises the block version to 5

* fix: run rustfmt on datalog/mod.rs

The file contained trailing slashes that made rustfmt crash

---------

Co-authored-by: Geoffroy Couprie <contact@geoffroycouprie.com>
…220)

Context: biscuit-auth/biscuit#130

This introduces the `HeterogeneousEqual` and `HeterogeneousNotEqual` operations, which will not return an error when their operands have different types, contrary to the existing `Equal` and `NotEqual` operations.

**breaking change**: this does not change the execution of existing tokens, but changes the text representation of the language. `Equal` was `==` and is now `===`, `NotEqual` was `!=` and is now `!==`, `HeterogeneousEqual` is `==` and `HeterogeneousNotEqual` is `!=`

---------

Co-authored-by: Geoffroy Couprie <contact@geoffroycouprie.com>
Co-authored-by: Clément Delafargue <clement@delafargue.name>
Copy link

codspeed-hq bot commented May 26, 2024

CodSpeed Performance Report

Merging #217 will not alter performance

Comparing v5 (3e3f071) with main (71f4350)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 67.91%. Comparing base (71f4350) to head (3e3f071).

Files Patch % Lines
biscuit-auth/src/datalog/expression.rs 62.16% 14 Missing ⚠️
biscuit-auth/src/datalog/mod.rs 82.00% 9 Missing ⚠️
biscuit-auth/src/token/authorizer.rs 30.00% 7 Missing ⚠️
biscuit-auth/src/format/convert.rs 64.28% 5 Missing ⚠️
biscuit-parser/src/builder.rs 28.57% 5 Missing ⚠️
biscuit-auth/src/token/builder.rs 62.50% 3 Missing ⚠️
biscuit-auth/examples/testcases.rs 98.36% 1 Missing ⚠️
biscuit-parser/src/parser.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   67.47%   67.91%   +0.43%     
==========================================
  Files          25       25              
  Lines        5347     5507     +160     
==========================================
+ Hits         3608     3740     +132     
- Misses       1739     1767      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants