Support for closures

[divarvel]

The goal of this branch is to explore how to add support for closures in the stack machine

• closures are represented as a list of ops and a list of parameter names

• closure parameters can be used like variables

• variable names must be unique, so shadowing is forbidden

• boolean operators use laziness and push the rhs closure on the ops list only if needed (without recursion)

• .any() and .all() use recursion to compute results

• closure support in datalog::expression::Op

• closure support in format::schema

• closure support in parser

• closures for lazy boolean operators

• closures for .any() and .all()

• prevent shadowing in closure arguments

  • evaluation
  • parsing & deserialization depends on feat: detect free variables in rule expressions #179

• print And and Or with &&! and ||!, without parsing them.

• v5 block detection depends on Add HeterogeneousEqual and HeterogeneousNotEqual to binary operation #220

[codspeed-hq]

CodSpeed Performance Report

Merging #202 will not alter performance

_{Comparing closures (fab2f24) with v5 (5bcac29)}

Summary

✅ 12 untouched benchmarks

[codecov]

Codecov Report

Attention: Patch coverage is 51.36364% with 107 lines in your changes are missing coverage. Please review.

Project coverage is 58.13%. Comparing base (5bcac29) to head (fab2f24).

Files	Patch %	Lines
biscuit-auth/src/format/convert.rs	23.33%	69 Missing ⚠️
biscuit-parser/src/parser.rs	64.86%	13 Missing ⚠️
biscuit-auth/src/token/builder.rs	20.00%	12 Missing ⚠️
biscuit-auth/src/datalog/expression.rs	91.30%	6 Missing ⚠️
biscuit-parser/src/builder.rs	0.00%	5 Missing ⚠️
biscuit-auth/src/datalog/mod.rs	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               v5     #202      +/-   ##
==========================================
- Coverage   58.27%   58.13%   -0.15%     
==========================================
  Files          23       23              
  Lines        4664     4820     +156     
==========================================
+ Hits         2718     2802      +84     
- Misses       1946     2018      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.